[Bug] SERVER_LONG_DESCRIPTION config option is incorrectly parsed as an array of strings in Docker #12

New Issue

2bitexclusion · 2024-04-24T21:31:12Z

2bitexclusion commented

2024-04-24 21:31:12 +00:00

Assuming I've got it correct, this bug was introduced with e31b9494af with this code:

if(gettype($from_config[$key]) != gettype($val) && !is_numeric($val)) {
(gen_config.php line 68)

Basically, when setting FOURGET_SERVER_LONG_DESCRIPTION in Docker, gen_config.php will incorrectly parse this environment variable (a string) into an array of strings.

I believe this happens because in the default configuration, SERVER_LONG_DESCRIPTION is set to null, so it assumes the env variable needs to be parsed due to a type mismatch check (null vs string). I'm not a PHP expert though so I'm just guessing here.

A simple workaround would be to just change the default config, so that SERVER_LONG_DESCRIPTION is some generic example string, much like SERVER_SHORT_DESCRIPTION.

Something similar is likely happening to MARGINALIA_API_KEY, but I don't use that at all so I can't double check.

Assuming I've got it correct, this bug was introduced with e31b9494af16bf833d14b6256ca055fa94b6f77b with this code: `if(gettype($from_config[$key]) != gettype($val) && !is_numeric($val)) {` (gen_config.php line 68) Basically, when setting `FOURGET_SERVER_LONG_DESCRIPTION` in Docker, gen_config.php will incorrectly parse this environment variable (a string) into an array of strings. I believe this happens because in the default configuration, `SERVER_LONG_DESCRIPTION` is set to `null`, so it assumes the env variable needs to be parsed due to a type mismatch check (null vs string). I'm not a PHP expert though so I'm just guessing here. A simple workaround would be to just change the default config, so that `SERVER_LONG_DESCRIPTION` is some generic example string, much like `SERVER_SHORT_DESCRIPTION`. Something similar is likely happening to `MARGINALIA_API_KEY`, but I don't use that at all so I can't double check.

❤️ 1

throwaway referenced this issue

2024-04-24 23:23:39 +00:00

fix treatment of config values with default of null and add php sodium #13

lolcat commented

2024-04-24 23:31:15 +00:00

throwaway should've fixed it, thank you for your time

lolcat closed this issue

2024-04-24 23:31:18 +00:00

Sign in to join this conversation.