lolcat
/
4get
6
13
Fork 4
Code Issues 13 Pull Requests Packages Projects Releases Wiki Activity

fix treatment of config values with default of null and add php sodium #13

Merged
lolcat merged 1 commits from docker_fix_gen_config into master 2024-04-24 23:27:15 +00:00
Conversation 0 Commits 1 Files Changed 3 +13 -11
throwaway commented 2024-04-24 23:23:39 +00:00
Collaborator
Copy Link

addresses #12

fixes docker/gen_config.php
if a value is passed via env where the default config contained null then there would be a type mismatch and the env value would be treated as an array of values
now, if a value is passed and the default value in config.php is null (SERVER_LONG_DESCRIPTION , MARGINALIA_API_KEY) then the value passed will not be split. In other words it will be assumed that this field will not contain an array of strings.

adds php83-sodium dependency

removes checking files in certificate directory when determining whether or not to use https. Only FOURGET_PROTO will be used to determine protocol which will save someone from pulling hairs out if they forget to uncomment mounting their certs and want to use http.

addresses #12 fixes docker/gen_config.php if a value is passed via env where the default config contained null then there would be a type mismatch and the env value would be treated as an array of values now, if a value is passed and the default value in config.php is null (SERVER_LONG_DESCRIPTION , MARGINALIA_API_KEY) then the value passed will not be split. In other words it will be assumed that this field will not contain an array of strings. adds php83-sodium dependency removes checking files in certificate directory when determining whether or not to use https. Only `FOURGET_PROTO` will be used to determine protocol which will save someone from pulling hairs out if they forget to uncomment mounting their certs and want to use http.
throwaway added 1 commit 2024-04-24 23:23:39 +00:00
lolcat merged commit 96f4fc927a into master 2024-04-24 23:27:15 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: lolcat/4get#13
No description provided.
Delete Branch "docker_fix_gen_config"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?